Remove hard-coded use of "lat", "ele", "ax" #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-20
to
-25
| dims: Annotated[Tuple[str, str, str], OpenLIFUFieldData("Dimension keys", "Codenames of the axes in the coordinate system being used")] = ("lat", "ele", "ax") | ||
| """Names of the axes in the coordinate system being used""" | ||
|
|
||
| names: Annotated[Tuple[str, str, str], OpenLIFUFieldData("Dimension names", "Human readable names of the axes in the coordinate system being used")] = ("Lateral", "Elevation", "Axial") | ||
| """"Human readable names of the axes in the coordinate system being used""" |
Collaborator
There was a problem hiding this comment.
With this we should we should update the example data in dvc -- I will push that change shortly
ebrahimebrahim
approved these changes
Jul 29, 2025
Collaborator
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
Looks great, thank you!
(force pushing to adjust a commit message)
Collaborator
|
(also rebasing to handle a merge conflict) |
For better backwards compatibility with protocols prior to #364
Ran the standardize_database.py script to do this.
ebrahimebrahim
force-pushed
the
364-inconsistent-use-of-dimension-names
branch
from
15e02f4 to
50e6943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the codebase to be less expectant of particular dimension names, and removes the ability to specify them in SimSetup, as this level of configuration doesn't provide enough benefit to overcome the risk of confusion
Closes #364