serialize TargetConstraints #347

[peterhollender]

Closes #347

[ebrahimebrahim]

Thank you! This would have been caught by the test

OpenLIFU-python/tests/test_protocol.py

Lines 39 to 41 in c83a133

	@pytest.mark.parametrize("compact_representation", [True, False])
	def test_serialize_deserialize_protocol(example_protocol : Protocol, compact_representation: bool):
	assert example_protocol.from_json(example_protocol.to_json(compact_representation)) == example_protocol

but I am guessing it didn't get caught because the protocol used for testing doesn't have any target constraints:

OpenLIFU-python/tests/resources/example_db/protocols/example_protocol/example_protocol.json

Line 91 in c83a133

"target_constraints": [],

Can you add some target constraints to tests/resources/example_db/protocols/example_protocol/example_protocol.json in this PR? Or I can, lmk

[peterhollender]

Thank you! This would have been caught by the test

OpenLIFU-python/tests/test_protocol.py

Lines 39 to 41 in c83a133

	@pytest.mark.parametrize("compact_representation", [True, False])
	def test_serialize_deserialize_protocol(example_protocol : Protocol, compact_representation: bool):
	assert example_protocol.from_json(example_protocol.to_json(compact_representation)) == example_protocol

but I am guessing it didn't get caught because the protocol used for testing doesn't have any target constraints:

OpenLIFU-python/tests/resources/example_db/protocols/example_protocol/example_protocol.json

Line 91 in c83a133

"target_constraints": [],

Can you add some target constraints to tests/resources/example_db/protocols/example_protocol/example_protocol.json in this PR? Or I can, lmk

This actually actually raises another issue, which is that by default Point objects have x, y, and z dims, but when we create solutions, we give those DataArrays lat, ele, and ax dims in transducer coordinate space. Similarly, when SlicerOpenLIFU converts and RAS point into transducer space, it makes that point use x, y, and z. So when I define target_constraints, I need to use x, y and z to be compatible with Slicer (as well as generic Point objects in scripts`, even though "transducer coordinates" will use lat, ele, ax...

[ebrahimebrahim]

This actually actually raises another issue, which is that by default Point objects have x, y, and z dims, but when we create solutions, we give those DataArrays lat, ele, and ax dims in transducer coordinate space. Similarly, when SlicerOpenLIFU converts and RAS point into transducer space, it makes that point use x, y, and z. So when I define target_constraints, I need to use x, y and z to be compatible with Slicer (as well as generic Point objects in scripts`, even though "transducer coordinates" will use lat, ele, ax...

Is this something we can fix in SlicerOpenLIFU? We can make it us lat, ele, ax if it is mis-using x,y,z somewhere

[ebrahimebrahim]

ty for updating the test data!