enhance_analysis for #334 #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix pulse train interval type and make text consistent
ebrahimebrahim
approved these changes
Jun 6, 2025
Collaborator
ebrahimebrahim
left a comment
ebrahimebrahim
left a comment
There was a problem hiding this comment.
Looks good, and it ran and displayed the new things in the SlicerOpenLIFU solution analysis table.
(This is not a "semantic" review -- I am not checking the physical correctness of the analysis but just the soundness of the code.)
| return cls(**parameter_dict) | ||
|
|
||
| def find_centroid(da: xa.DataArray, cutoff:float) -> np.ndarray: | ||
| def find_centroid(da: xa.DataArray, cutoff:float, units:None) -> np.ndarray: |
Collaborator
There was a problem hiding this comment.
(We should probably unit test things like find_centroid but we have all been foregoing a lot of that to get things together. Technical debt to be repaid)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following attributes to
SolutionAnalysis:target_position_lat_mmtarget_position_ele_mmtarget_position_ax_mmfocal_centroid_lat_mmfocal_centroid_ele_mmfocal_centroid_ax_mmduty_cycle_pulse_train_pctduty_cycle_sequence_pctsequence_duration_sSome of the display format for other dimension based parameters are updated as well.
Significant figures on all items in solution analysis when generating a table are also refined.