Skip to content

Conversation

@ebrahimebrahim
Copy link
Collaborator

@ebrahimebrahim ebrahimebrahim commented May 28, 2025

  • Splits out skin mesh computation from virtual fit function to its own function compute_skin_mesh_from_volume. Allow skin mesh to optionally be . This is what @sadhana-r had already done (before my interruption 😁), and is needed for SlicerOpenLIFU#195.
  • Adds an option to return a packet of debugging info VirtualFitDebugInfo.
  • Adds an option to include a progress callback in both the virtual fitting and the mesh reconstruction.

For Review

@ebrahimebrahim
Copy link
Collaborator Author

ebrahimebrahim commented May 28, 2025

@dlichy only adding you for visibility since this touches the run_reconstruction function; feel free to comment if you have any comments, but no need to review

Copy link
Contributor

@sadhana-r sadhana-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over the code and tested as part of OpenwaterHealth/SlicerOpenLIFU#381. Changed looks good to me!

@ebrahimebrahim ebrahimebrahim force-pushed the 316-provide-more-virtual-fit-debugging-info branch from ad68046 to 6f99537 Compare May 28, 2025 14:22
@ebrahimebrahim ebrahimebrahim enabled auto-merge (rebase) May 28, 2025 14:22
@ebrahimebrahim ebrahimebrahim merged commit 3b4a5c9 into main May 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants