Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error testing in DelayClaimable tests #677

Conversation

ernestas2k
Copy link
Contributor

  • πŸ“˜ I've reviewed the OpenZeppelin Contributor Guidelines
  • βœ… I've added tests where applicable to test my new functionality.
  • πŸ“– I've made sure that my contracts are well-documented.
  • 🎨 I've run the JavaScript linter (npm run lint:fix) and fixed all issues.

Fixes #672


πŸš€ Description

Replaced try catches in DelayedClaimable with assertRevert

@frangio
Copy link
Contributor

frangio commented Jan 15, 2018

Thanks @ernestas2k! πŸ˜„

@frangio frangio merged commit 7532dab into OpenZeppelin:master Jan 15, 2018
@ernestas2k
Copy link
Contributor Author

My pleasure to contribute to the project, @frangio πŸ‘

ProphetDaniel pushed a commit to classicdelta/Smart-Contracts that referenced this pull request Mar 9, 2018
…-in-delayed-claimable#672

Fix error testing in DelayClaimable tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error testing in DelayClaimable tests
2 participants