Refactor assert revert helper to encapsulate promises #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facuspagnuolo
changed the title
facuspagnuolo
changed the title
federicobond
previously approved these changes
Dec 26, 2017
test/helpers/assertRevert.js
Outdated
| assert.fail('Expected revert not received'); | ||
| } catch (error) { | ||
| const revertFound = error.message.search('revert') >= 0; | ||
| console.log('Revert found: ', revertFound); |
There was a problem hiding this comment.
Remove this console.log.
facuspagnuolo
force-pushed
the
refactor/assert_revert_to_encapsulate_promises
branch
2 times, most recently
from
98b8dcb to
8c02b9a
Compare
facuspagnuolo
force-pushed
the
refactor/assert_revert_to_encapsulate_promises
branch
from
8c02b9a to
55c59f8
Compare
|
@federicobond I rebased this PR from master so it can be merged before #627. Actually #627 now depends on this PR. Please review |
|
Please remove the Everything else looks good! 🎄 |
facuspagnuolo
force-pushed
the
refactor/assert_revert_to_encapsulate_promises
branch
from
55c59f8 to
4173800
Compare
|
done @federicobond :) |
|
will not the catch also catch the assert.fail('...')? |
facuspagnuolo
added a commit
to facuspagnuolo/zeppelin-solidity
that referenced
this pull request
Jan 28, 2018
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this pull request
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.