test: add tests for max64 and min64 from Math #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted to learn more about solidity, and contribute a little bit. So I started with the most basic missing test I could find :) There's one thing I don't really understand. I copied everything from the SafeMath tests, and instead of returning the values, the functions in the mock save them in the result attribute. Is there a reason for that? |
eternauta1337
added
review
good first issue
AugustoL
approved these changes
Jan 5, 2018
|
Thanks @ElOpio! 🙌 The result state variable came from the time SafeMath was a base contract. Not sure why it was done that way. Perhaps @maraoz can shed some light. |
|
Not sure either, but I think we can keep it this way and refactor later. |
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this pull request
Mar 9, 2018
test: add tests for max64 and min64 from Math
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.