Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support foundry v1.0 #5511

Merged
merged 2 commits into from
Feb 15, 2025
Merged

Support foundry v1.0 #5511

merged 2 commits into from
Feb 15, 2025

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 14, 2025 •
edited
Loading

Foundry v1.0 stable was released. This requires

  • updating submodules (in particular the erc4626 tests)
  • fixing some fuzzing tests

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@Amxx Amxx added tests Test suite and helpers. ignore-changeset labels Feb 14, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: af727b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx requested review from arr00 and ernestognw February 14, 2025 19:35
@Amxx Amxx changed the title Update submodule for foundry v1.0 stable Support foundry v1.0 Feb 14, 2025
arr00
arr00 approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@arr00 arr00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fewer breaking changes than I expected. Nice

@Amxx Amxx merged commit 9586aaf into OpenZeppelin:master Feb 15, 2025
17 checks passed
@Amxx Amxx deleted the chore/update-submodules branch February 15, 2025 19:54
@Amxx Amxx mentioned this pull request Feb 15, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arr00 arr00 arr00 approved these changes

@ernestognw ernestognw Awaiting requested review from ernestognw

Assignees
No one assigned
Labels
ignore-changeset tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @arr00