Make explicit the validity of the empty set in MerkleProof.sol #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ernestognw
changed the title
cairoeth
approved these changes
Aug 7, 2024
Yes, I'll pick it up to #5139 |
ernestognw
added a commit
to Amxx/openzeppelin-contracts
that referenced
this pull request
Aug 7, 2024
3 tasks
Amxx
pushed a commit
that referenced
this pull request
Oct 2, 2024
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it explicit that users verifying multiproofs should consider that the empty set is valid.
Most implementations do check the validity of the leaves or build them within the contract, which makes it impossible to validate a proof incorrectly.
This is consistent with our no-ops policy
PR Checklist
npx changeset add)