Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect Packing.pack and Packing.replace against values that include dirty bits #5117

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jul 21, 2024

  • If any of the argument of pack contains dirty bits, this could affect the packing.
  • Same for replace: if the new value has dirty bits, that may touch the part that is not supposed to be modified.

For extract and replace, the self argument is assumed to be clean (which would be the case if it was produced by pack. Also if it is not clean, the dirty part is preserved by replace, and not extractable by extract (bound check)

@Amxx Amxx added this to the 5.1 milestone Jul 21, 2024
@Amxx Amxx requested review from ernestognw and cairoeth July 21, 2024 16:57
Copy link

changeset-bot bot commented Jul 21, 2024

⚠️ No Changeset found

Latest commit: 4b9f2a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx changed the title Protect Packing.pack and Packing.replace against values that include dirty upper bits Protect Packing.pack and Packing.replace against values that include dirty bits Jul 21, 2024
@Amxx Amxx merged commit 19a657b into OpenZeppelin:master Jul 21, 2024
24 checks passed
@Amxx Amxx deleted the fix/packing-with-dirty-bits branch July 21, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants