Update Arbitrum's vendored contracts to Nitro #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Amxx for submitting this. 💜 |
frangio
reviewed
Sep 27, 2022
frangio
reviewed
Sep 27, 2022
Do we need these annotations for some technical reason? I would prefer to remove them. Is this PR ready to be moved out of Draft? |
Co-authored-by: Francisco <frangio.1@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
It did not feel right to vendor a modified version of Arbitrum's code without documenting the changes. |
frangio
pushed a commit
that referenced
this pull request
Sep 30, 2022
Co-authored-by: Francisco <frangio.1@gmail.com> (cherry picked from commit 9938a85)
JulissaDantes
pushed a commit
to JulissaDantes/openzeppelin-contracts
that referenced
this pull request
Nov 3, 2022
Co-authored-by: Francisco <frangio.1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor contract from arbitrum nitro
Some types have been changed (for example from
IOwnabletoaddress. The change are marked by// OZ: retyped from xxxPR Checklist