Reorder arguments for multiProof functions#3447
Merged
Amxx merged 9 commits intoOpenZeppelin:masterfrom Jun 3, 2022
Merged
Conversation
Collaborator
|
While I understand the logic here, I must say I'm not a fan of this new format. In particular because it separates the proof and the proofFlag arguments. The thing is, in multiProofVerify, the Afaik, the idea for having the proof being the first argument of the single version was to be able to do: IMO this was a bad design from the start. Rater then proving a property on the proof, using the root, I would rather prove a property on the tree itself (namely that it contains a leaf) using the proof as an argument. So I would personally have preferred
|
Contributor
Author
|
Reordered to |
…ppelin-contracts into merkle-multiproof-reorder
Amxx
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves part of #3441.
Reorders arguments for consistency with simple proofs.