Documentation Nit: Remove Misleading Documentation in ERC721Burnable #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
ERC721's
_burnimplementation does not irrevocably burn the token. Contracts that inherit from ERC721/ERC721 Burnable and expose a public burn function are able to re-mint burned tokens through the _mintfunction unless overridden/modified by the deployer/implementor.This PR is literally a nit, but removes the "irrevocably" word from the description. The motivation of this PR was confusion by newer devs directly cloning OZ's implementations.
PR Checklist