Improve security of the onlyGovernance modifier #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
part of an execute operation
frangio
reviewed
Jan 28, 2022
contracts/governance/Governor.sol
Outdated
Comment on lines
56
to
57
| require(_msgSender() == _executor(), "Governor: onlyGovernance"); | ||
| _governanceCall[msg.data].decrement(); |
There was a problem hiding this comment.
I think we should put this in an internal function to optimize bytecode size.
frangio
reviewed
Feb 17, 2022
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
frangio
changed the title
frangio
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a potential issue where a timelock used by a governor having multiple proposers could result in some of these proposers attacking the timelock.
PR Checklist