Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for RFC 2606 #2802

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Update tests for RFC 2606 #2802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11bff22
Update tests for RFC 2606
fulldecent Jul 31, 2021
509ff97
Update tests for RFC 2606
fulldecent Jul 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/token/ERC721/ERC721.behavior.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const Error = [ 'None', 'RevertWithMessage', 'RevertWithoutMessage', 'Panic' ]
const firstTokenId = new BN('5042');
const secondTokenId = new BN('79217');
const nonExistentTokenId = new BN('13');
const baseURI = 'https://api.com/v1/';
const baseURI = 'https://api.example.com/v1/';

const RECEIVER_MAGIC_VALUE = '0x150b7a02';

Expand Down Expand Up @@ -929,7 +929,7 @@ function shouldBehaveLikeERC721Metadata (errorPrefix, name, symbol, owner) {

it('token URI can be changed by changing the base URI', async function () {
await this.token.setBaseURI(baseURI);
const newBaseURI = 'https://api.com/v2/';
const newBaseURI = 'https://api.example.com/v2/';
await this.token.setBaseURI(newBaseURI);
expect(await this.token.tokenURI(firstTokenId)).to.be.equal(newBaseURI + firstTokenId.toString());
});
Expand Down
4 changes: 2 additions & 2 deletions test/token/ERC721/extensions/ERC721URIStorage.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ contract('ERC721URIStorage', function (accounts) {
await this.token.mint(owner, firstTokenId);
});

const baseURI = 'https://api.com/v1/';
const baseURI = 'https://api.example.com/v1/';
const sampleUri = 'mock://mytoken';

it('it is empty by default', async function () {
Expand Down Expand Up @@ -62,7 +62,7 @@ contract('ERC721URIStorage', function (accounts) {
await this.token.setBaseURI(baseURI);
await this.token.setTokenURI(firstTokenId, sampleUri);

const newBaseURI = 'https://api.com/v2/';
const newBaseURI = 'https://api.example.com/v2/';
await this.token.setBaseURI(newBaseURI);
expect(await this.token.tokenURI(firstTokenId)).to.be.equal(newBaseURI + sampleUri);
});
Expand Down