Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set EVM to Paris for the release process #4503

Open
Amxx opened this issue Aug 2, 2023 · 2 comments
Open

Set EVM to Paris for the release process #4503

Amxx opened this issue Aug 2, 2023 · 2 comments
Labels
automation Tests and coverage running. Docsite publishing.

Comments

@Amxx
Copy link
Collaborator

Amxx commented Aug 2, 2023

Following #4489 (comment)

Since 0.8.20, the default EVM target is shanghai, which includes the push0 oppcode. When releasing the package, with artefacts that the upgrades plugin will rely on, we should not target such a recent EVM version, as the produced bytecode will not be supported by many chains.

In hardhat.config.json we should add a target/compilerTarget flag, that by default would be shanghai. When doing the release process, that envvar should be set to paris

@Amxx
Copy link
Collaborator Author

Amxx commented Aug 2, 2023

@frangio @ericglau

@Amxx Amxx added the automation Tests and coverage running. Docsite publishing. label Aug 2, 2023
@Amxx Amxx added this to the 5.0 milestone Aug 2, 2023
@frangio
Copy link
Contributor

frangio commented Aug 2, 2023

Let's set up a matrix to run tests on both paris and shanghai. The only one that doesn't need this is the coverage check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Tests and coverage running. Docsite publishing.
Projects
None yet
Development

No branches or pull requests

2 participants