Skip to content

Commit ab9cc4c

Browse files
0xalpharushfrangio
andcommitted
Ignore reentrancy inexecuteBatch and update Slither config (#3955)
Co-authored-by: Francisco <fg@frang.io> (cherry picked from commit a5af0ad)
1 parent 43aa7ff commit ab9cc4c

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

.github/workflows/checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ jobs:
7676
- uses: actions/checkout@v3
7777
- name: Set up environment
7878
uses: ./.github/actions/setup
79-
- uses: crytic/slither-action@v0.1.1
79+
- uses: crytic/slither-action@v0.2.0
8080

8181
codespell:
8282
if: github.repository != 'OpenZeppelin/openzeppelin-contracts-upgradeable'

contracts/governance/TimelockController.sol

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,9 @@ contract TimelockController is AccessControl, IERC721Receiver, IERC1155Receiver
316316
*
317317
* - the caller must have the 'executor' role.
318318
*/
319+
// This function can reenter, but it doesn't pose a risk because _afterCall checks that the proposal is pending,
320+
// thus any modifications to the operation during reentrancy should be caught.
321+
// slither-disable-next-line reentrancy-eth
319322
function executeBatch(
320323
address[] calldata targets,
321324
uint256[] calldata values,

slither.config.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
22
"detectors_to_run": "reentrancy-eth,reentrancy-no-eth,reentrancy-unlimited-gas",
3-
"filter_paths": "contracts/mocks"
3+
"filter_paths": "contracts/mocks",
4+
"compile_force_framework": "hardhat"
45
}

0 commit comments

Comments
 (0)