Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter lack of package.json #448

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Fix linter lack of package.json #448

merged 2 commits into from
Sep 8, 2022

Conversation

martriay
Copy link
Contributor

@martriay martriay commented Sep 2, 2022

Fixes #447.

ericnordelo
ericnordelo reviewed Sep 5, 2022
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the npm install npm line necessary?

@andrew-fleming
Copy link
Collaborator

Is the npm install npm line necessary?

No, it's not needed. Good call

@martriay
Copy link
Contributor Author

martriay commented Sep 7, 2022

removed

ericnordelo
ericnordelo approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martriay martriay merged commit a197b94 into main Sep 8, 2022
@martriay martriay deleted the fix-linter branch September 8, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnordelo ericnordelo ericnordelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linter from tox fails if you have a package.json in a parent directory
3 participants
@martriay @andrew-fleming @ericnordelo