Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-standard increase_allowance and decrease_allowance from ERC20 #728

Closed
milancermak opened this issue Sep 12, 2023 · 4 comments · Fixed by #881
Closed

Remove non-standard increase_allowance and decrease_allowance from ERC20 #728

milancermak opened this issue Sep 12, 2023 · 4 comments · Fixed by #881
Assignees

Comments

@milancermak
Copy link
Contributor

🧐 Motivation

The Starknet equivalent to the recent ERC20 update of Solidity contracts. Having these methods is even less necessary on Starknet thanks to AA and multicall.

Additional benefit of removing them is slightly reduced contract size.

Since the Cairo 2 contracts haven't been officially released, I think it's a good opportunity to squeeze this in 🤞

@martriay
Copy link
Contributor

+1, although I don't think this will make it to the release.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Contracts for Cairo Dec 10, 2023
@martriay martriay modified the milestones: after, later Dec 10, 2023
@martriay martriay modified the milestones: later, after Jan 26, 2024
@TAdev0
Copy link
Contributor

TAdev0 commented Jan 30, 2024

@martriay I just saw your message on the starknet Cairo core stars channel. May I work on this issue?
Thank you.

@martriay
Copy link
Contributor

Thanks for volunteering! You can tackle either this or #841, but I suggest you start with one at the time :)

@TAdev0
Copy link
Contributor

TAdev0 commented Jan 30, 2024

sure! will work on this one tonight :)

@martriay martriay moved this from 📋 Backlog to 🏗 In progress in Contracts for Cairo Jan 31, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Resolved in Contracts for Cairo Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants