Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting engine to ARM64 architecture #532

Merged
merged 27 commits into from
Mar 13, 2020
Merged

Porting engine to ARM64 architecture #532

merged 27 commits into from
Mar 13, 2020

Conversation

Zigatun
Copy link
Contributor

@Zigatun Zigatun commented Dec 23, 2019

No description provided.

@q4a q4a self-requested a review March 13, 2020 07:00
Copy link
Member

@q4a q4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix few spaces.

@@ -48,9 +50,14 @@ void Initialize()
Skin2W = Skin2W_CPP;
Skin3W = Skin3W_CPP;
Skin4W = Skin4W_CPP;
PLCCalc = PLCCalc_SSE;
#if defined(XR_ARM64)
PLCCalc = PLCCalc_CPP;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace tabs with 4 space, please. And in else section.

Suggested change
PLCCalc = PLCCalc_CPP;
PLCCalc = PLCCalc_CPP;

@@ -0,0 +1,2793 @@
#ifndef SSE2NEON_H
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you take it from https://github.com/DLTcollab/sse2neon ?

#if defined(XR_ARM64)
PLCCalc = PLCCalc_CPP;
#else
PLCCalc = PLCCalc_SSE;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PLCCalc = PLCCalc_SSE;
PLCCalc = PLCCalc_SSE;

Comment on lines +221 to +223
int64_t virtual_timer_value;
asm volatile("mrs %0, cntvct_el0" : "=r"(virtual_timer_value));
return virtual_timer_value;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 4 space, please.

Suggested change
int64_t virtual_timer_value;
asm volatile("mrs %0, cntvct_el0" : "=r"(virtual_timer_value));
return virtual_timer_value;
int64_t virtual_timer_value;
asm volatile("mrs %0, cntvct_el0" : "=r"(virtual_timer_value));
return virtual_timer_value;

@q4a q4a merged commit 097e655 into OpenXRay:xd_dev Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants