Porting engine to ARM64 architecture #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xottab-DUTY
reviewed
Dec 24, 2019
q4a
requested changes
Mar 13, 2020
| @@ -48,9 +50,14 @@ void Initialize() | |||
| Skin2W = Skin2W_CPP; | |||
| Skin3W = Skin3W_CPP; | |||
| Skin4W = Skin4W_CPP; | |||
| PLCCalc = PLCCalc_SSE; | |||
| #if defined(XR_ARM64) | |||
| PLCCalc = PLCCalc_CPP; | |||
There was a problem hiding this comment.
Replace tabs with 4 space, please. And in else section.
Suggested change
| PLCCalc = PLCCalc_CPP; | |
| PLCCalc = PLCCalc_CPP; |
| @@ -0,0 +1,2793 @@ | |||
| #ifndef SSE2NEON_H | |||
There was a problem hiding this comment.
Did you take it from https://github.com/DLTcollab/sse2neon ?
| #if defined(XR_ARM64) | ||
| PLCCalc = PLCCalc_CPP; | ||
| #else | ||
| PLCCalc = PLCCalc_SSE; |
There was a problem hiding this comment.
Suggested change
| PLCCalc = PLCCalc_SSE; | |
| PLCCalc = PLCCalc_SSE; |
Comment on lines
+221
to
+223
| int64_t virtual_timer_value; | ||
| asm volatile("mrs %0, cntvct_el0" : "=r"(virtual_timer_value)); | ||
| return virtual_timer_value; |
There was a problem hiding this comment.
Use 4 space, please.
Suggested change
| int64_t virtual_timer_value; | |
| asm volatile("mrs %0, cntvct_el0" : "=r"(virtual_timer_value)); | |
| return virtual_timer_value; | |
| int64_t virtual_timer_value; | |
| asm volatile("mrs %0, cntvct_el0" : "=r"(virtual_timer_value)); | |
| return virtual_timer_value; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.