Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement game_cl_mp::generate_file_name #301

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Reimplement game_cl_mp::generate_file_name #301

merged 1 commit into from
Dec 18, 2018

Conversation

FreeZoneMods
Copy link
Contributor

Make crossplatform implementation instead of ifdefing it.

@FreeZoneMods FreeZoneMods mentioned this pull request Dec 17, 2018
Closed
@Xottab-DUTY Xottab-DUTY requested a review from q4a December 17, 2018 13:08
@FreeZoneMods
Reimplement game_cl_mp::generate_file_name
295b155 
Make crossplatform implementation instead of ifdefing it.
@q4a
Copy link
Member

q4a commented Dec 17, 2018

I tested it in separate branch (my clang fixes + this PR): https://github.com/q4a/xray-16/tree/clang-merge-pr301
Builds without errors on my system and travis: https://travis-ci.org/q4a/xray-16/builds/469118908
Runs and playable on Ubuntu 18.10 Nvidia GeForce GT 730, proprietary driver version 415.18.

@q4a q4a merged commit 73d7fc1 into OpenXRay:xd_dev Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@q4a q4a q4a approved these changes

Assignees
No one assigned
Labels
Portability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FreeZoneMods @q4a @Xottab-DUTY