Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Add support for "enable_stt_selection", "enable_tts_selection", "enable_backend_selection" #29

Closed
AIIX opened this issue Oct 11, 2022 · 2 comments · Fixed by #37
Closed
Assignees
Labels
enhancement New feature or request

Comments

@AIIX
Copy link

AIIX commented Oct 11, 2022

Workflow changes ?

  • Option "enable_backend_selection":

    • What pages need to be show once this is disabled ?
    • How does it affect page selection ?
    • Voice Process Changes ?
  • Option "enable_tts_selection":

    • Same as above
  • Option "enable_stt_selection":

    • Same as above
  • Additionally what happens when all three are disabled ?

    • Setup skill itself should not activate, since there is now no need for setup skill at all ?
@JarbasAl
Copy link
Member

you are overthinking it, for every option, if not enabled simply skip that step and use default values

skip backend -> just leave whatever already is in mycroft.conf (same as offline backend)
skip TTS -> just leave whatever already is in mycroft.conf
skip STT -> just leave whatever already is in mycroft.conf

all disabled -> simply goes trough the offline backend route, creates a identity2.json and starts loading skills. will also wait for wifi setup etc before reporting ready

@JarbasAl
Copy link
Member

JarbasAl commented Oct 11, 2022

have a look at https://github.com/OpenVoiceOS/ovos-backend-client

it now supports arbitrary number of backends, so in the future we may add even more such as neon and ovos (see open PR for those)

offline still counts as a backend, since it now provides all expected functionality on device, this means you can set your own wolfram keys etc and it will all just work in the skills without changes via the Api classes. Pairing with local backend just means creating a dummy identity2.json file basically

OCA - https://github.com/OpenVoiceOS/ovos-config-assistant also integrates with all offline backend features, such as providing OAuth

@JarbasAl JarbasAl added the enhancement New feature or request label Oct 11, 2022
@JarbasAl JarbasAl self-assigned this Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants