Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some dep updates #1020

Merged
merged 1 commit into from
Jun 10, 2016
Merged

Some dep updates #1020

merged 1 commit into from
Jun 10, 2016

Conversation

Martii
Copy link
Member

@Martii Martii commented Jun 10, 2016

  • bug fixes, etc... please read their CHANGELOGs
  • Fix README.md linkage

NOTES

  • Waiting on jquery ... usually major releases are a bit too buggy.

Some dep updates
fff5aea 
* bug fixes, etc... please read their CHANGELOGs
* Fix README.md linkage

**NOTES**
* Waiting on *jquery* ... usually major releases are a bit too buggy.
@Martii Martii added migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jun 10, 2016
@Martii Martii merged commit 1f06103 into OpenUserJS:master Jun 10, 2016
@Martii Martii deleted the someDepUpdates branch June 10, 2016 18:34
@Martii
Copy link
Member Author

Martii commented Jun 10, 2016 •
edited
Loading

Hmmm...

$ npm --depth 0 outdated
Package                       Current            Wanted      Latest  Location
...
mongodb                        2.1.21            2.1.21      2.1.18  mongodb
...

@christkv
Why does npm and npmjs.com show v2.1.18 now instead of the last two that we've been notified to upgrade to?

Should we be reverting back to 2.1.18?

Thanks for stopping in for a brief moment.

@Martii
Copy link
Member Author

Martii commented Jun 17, 2016 •
edited
Loading

jQuery 3.0.0 definitely isn't working with express via modals in bootstrap in a retest.

Dep of dep for #904

@christkv
Copy link

There are some issues related to 2.1.19-21 that makes it not ideal for upgrade. Instead of pulling them I set 2.1.18 as latest to avoid people pulling them less they explicitly want to. I'm working on a 2.2.0 driver that contains refactorings to address the core issues.

@Martii
Copy link
Member Author

Martii commented Jun 20, 2016

Okee dokee... thanks... so far in the last 10 days it's been status quo with the dep that needs this with .21 but haven't dug real deep into it.

Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Jun 21, 2016
Some dep updates and one downgrade
1b21961 
* Bug fixes, etc... see their CHANGELOGs
* *jquery*@3.0.0 followup... does not appear to work at all with *bootstrap* modals... see related at OpenUserJS#904
* Retested delete op
* *mongodb* appears to be in the middle of a refactor and as a precaution for the backend VPS, and what is scheduled for maintenance, downgrading to announced stable just to be sure... See OpenUserJS#1020 (comment) . No detected issues in our usage yet in the last week and a half though.
@Martii Martii mentioned this pull request Jun 21, 2016
Merged
@Martii
Copy link
Member Author

Martii commented Jul 25, 2016 •
edited
Loading

jquery and bootstrap modal incompatibility fixed in dev bootstrap with twbs/bootstrap#20338 (base issue of twbs/bootstrap#16834). Hopefully the next v3.x release of bootstrap will be soon as it is stalling normative migration. Since jQuery is a known dependent and confirmed as being:

DaSchTour wrote:

It's an error in package.json

... an error as "missing" in doing an issue reference to #904

Also from the last time modals were touched the modal demo at http://getbootstrap.com/javascript/#static-example has changed a bit.

Adding mitigation watchpoint.

As discussed over there live demos are using even older versions of jQuery than we are and may not be used as validity tests. Seems I've stepped into their Pandora box over there as well.

@Martii Martii added the needs mitigation Needs additional followup. label Jul 25, 2016
@Martii Martii removed the needs mitigation Needs additional followup. label May 15, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. migration Use this to indicate that it may apply to an existing or announced migration.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martii @christkv