-
Notifications
You must be signed in to change notification settings - Fork 1
Remove estimagic related files #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
===========================================
- Coverage 93.24% 78.05% -15.20%
===========================================
Files 247 68 -179
Lines 17987 4666 -13321
===========================================
- Hits 16772 3642 -13130
+ Misses 1215 1024 -191
... and 127 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I went over all the imports and a couple of places where I thought you might miss something. Looks very good! I would suggest a few more infrastructure simplifications:
- The
rtd_environmenthas some redundant packages and is missing estimagic - The folder
docs/source/scriptscan be deleted - MANIFEST.in mentions
.dbfiles. I think we can remove that -
pytaskandclickcan be removed fromenvironment.yml -
pytaskrelated options can be removed frompyproject.toml - Some of the ignored warnings in pyproject.toml can be removed
I would suggest we merge quickly and get the new package up on PyPi and conda-forge. We don't have users yet and can always fix a few more rough edges later.
Changes
tranquilofolder directly undersrcsubsolverfolder intranquiloexploration_sample.pyfromtiktok.pyutilities.pyfromutilities.pytranquiloin__init__.pywrapped_subsolver.pytosubsolvers