Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Create base Antora setup #85

Merged
merged 5 commits into from
Oct 11, 2022
Merged

Conversation

philipwindecker
Copy link
Contributor

@philipwindecker philipwindecker commented Sep 15, 2022

Reference to a related issue in the repository

#86

Add a description

Applies the Antora base structure to the repo.

Mention a member

@pmai

Check the checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-sensor-model-packaging.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / Github Actions pass locally with my changes.

@philipwindecker philipwindecker added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Sep 15, 2022
@philipwindecker philipwindecker linked an issue Sep 15, 2022 that may be closed by this pull request
@philipwindecker
Copy link
Contributor Author

The default branch is still "master". Should it be renamed to "main" in this process?

Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB decision on 2022-10-10:

  • PR has been adjusted as per CCB decisions
  • Further approved chagnes: Switch to wide view, adjust Repo link to OSMP
  • With those changes the PRs can be merged to master: Unanimous Agreement
  • Future work is needed on BibTeX bibliography prior to 3.6.0, to be discussed at the end of the year
  • Triggering of documentation build to be added later on via Office generated PAT

@philipwindecker philipwindecker merged commit 1241cec into master Oct 11, 2022
@philipwindecker philipwindecker deleted the antora/base-antora-setup branch October 11, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WP22: Documentation update to Antora
2 participants