-
Notifications
You must be signed in to change notification settings - Fork 129
Add orientation rate to PedestrianAttributes::Bone #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add orientation rate to PedestrianAttributes::Bone #769
Conversation
CCB 2024-01-29: Should be reviewed by @Peintnerer and @thempen, especially if also velocity should be added, as there is no directly specified relationship between position changes and hierarchical orientation_rate since we have no specified kinematic model (positions and hence gaps between bones can vary over time depending on modeling approaches). Therefore it might be a good idea to include velocity to provide all of the information the internal model has to consumers. To be re-revied at next CCB. |
We thought about it again and came to the conclusion, that also adding the translatory velocity makes sense, mainly because the shoulders and legs are disconnected from the spine. So there can be independent translatory movement. I added the velocity in the proto file as a suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can definitely see that having information about the bone's velocity and orientation rate makes sense. This is probably dependent on the modeling approach or motion capture method used, but I can imagine a few applications in which this might come in handy.
CCB 2024-02-12: Decision merge as-is. |
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
7cac1f2
to
19bc76b
Compare
reviewed for v3.7.0 |
Reference to a related issue in the repository
#747
Add a description
Add orientation rate to the bone class. The translatory velocity of the bones can be calculated with the orientation rate of the parent bones.
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board: