Skip to content

Fix streaming principle image reference #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix streaming principle image reference #767

merged 1 commit into from
Apr 4, 2024

Conversation

thomassedlmayer
Copy link
Contributor

Image on streaming update principle is not displayed because its file extension has upper case letters.

@thomassedlmayer thomassedlmayer added Bug Problems in the build system, build scripts, etc or faults in the interface. Documentation Everything which impacts the quality of the documentation and guidelines. labels Jan 23, 2024
@thomassedlmayer thomassedlmayer added this to the V3.7.0 milestone Jan 23, 2024
@thomassedlmayer thomassedlmayer force-pushed the fix/docs-streaming-update-image branch from 25720f3 to 8b39430 Compare January 24, 2024 08:50
@pmai pmai self-assigned this Feb 19, 2024
@pmai pmai self-requested a review February 19, 2024 16:12
@thomassedlmayer thomassedlmayer added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Mar 28, 2024
pmai
pmai approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CCB 2024-04-04: Merge as-is.

@pmai pmai added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Apr 4, 2024
@thomassedlmayer @pmai
Rename streaming update image to lowercase
427d7a6 
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
@pmai pmai force-pushed the fix/docs-streaming-update-image branch from 8b39430 to 427d7a6 Compare April 4, 2024 08:54
@pmai pmai merged commit 3524cb1 into OpenSimulationInterface:master Apr 4, 2024
5 checks passed
jdsika
jdsika reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@jdsika jdsika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for v3.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdsika jdsika jdsika left review comments

@pmai pmai pmai approved these changes

Assignees

@pmai pmai

Labels
Bug Problems in the build system, build scripts, etc or faults in the interface. Documentation Everything which impacts the quality of the documentation and guidelines. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
V3.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thomassedlmayer @pmai @jdsika