Skip to content

Move missing vcpkg information to prerequisites #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

pmai
Copy link
Contributor

@pmai pmai commented Jun 15, 2023

Adds additional vcpkg build information from OSMP, drops redundant build steps in prerequisites, moving them to the installing documentation.

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
@pmai pmai added the Documentation Everything which impacts the quality of the documentation and guidelines. label Jun 15, 2023
@pmai pmai added this to the V3.6.0 milestone Jun 15, 2023
@pmai pmai self-assigned this Jun 15, 2023
@0815-code
Copy link
Contributor

Would it also be possible to add also OSI to vcpkg?

@pmai pmai added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Jun 16, 2023
@pmai
Copy link
Contributor Author

pmai commented Jun 16, 2023

Technically I do not think this is much of a problem, however this needs to be decided organizationally and also done ;).

@ThomasNaderBMW
Copy link
Contributor

CCB Review, 19.06.23:

Can be merged.

@ThomasNaderBMW ThomasNaderBMW added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Jun 19, 2023
@pmai pmai merged commit 541ea52 into master Jun 21, 2023
@pmai pmai deleted the fix/install-instructions-vcpkg branch June 21, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Everything which impacts the quality of the documentation and guidelines. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants