-
Notifications
You must be signed in to change notification settings - Fork 129
Links in README and example moved to docu #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links in README and example moved to docu #720
Conversation
@philipwindecker I do not know, if Syntax highlighting will work for the python-script example. |
@philipwindecker I changed the links to the official docu and the classes list to antora, as there was a todo. Please check that, as well. |
Not as is. The source is set to ruby instead of python, therefore applying different styling rules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the things I mentioned in doc/architecture/trace_file_example.adoc
myself.
@philipwindecker is this ok for you, as well? |
d714678
to
1c6244e
Compare
CCB on 2023-03-27: Merge as-is. |
Signed-off-by: Philipp Rosenberger <philipp.rosenberger@partner.bmw.de>
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
1c6244e
to
21d231f
Compare
Reference to a related issue in the repository
This PR should solve #719.
Add a description
As discussed in the last CCB meeting, we should change the README to only link to the usage examples in the official documentation.
Required steps:
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!