Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tp/add polyline model #484 #688

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Feature/tp/add polyline model #484 #688

wants to merge 9 commits into from

Conversation

0815-code
Copy link
Contributor

Reference to a related issue in the repository

Add a reference to a related issue in the repository.

Add a description

Add a description of the changes proposed in the pull request.

Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

philipwindecker and others added 9 commits November 9, 2022 10:30
@philipwindecker @0815-code
Changed version naming for master branch
9fa5baa 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@philipwindecker @0815-code
build: Updated ubuntu image
7e07f4e 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@philipwindecker @0815-code
Added new antora generator trigger
d7c6ff1 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@philipwindecker @0815-code
Removed test branch from "on" keyword
e7d0b13 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@philipwindecker @0815-code
Removed broken references to deleted submodules
5e83a90 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@philipwindecker @0815-code
Update of pipeline cache action and key to
b902794 
force a rebuild of protobuf

Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@philipwindecker @0815-code
Fixed outdated cache dependency for protobuf 3
a888913 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@0815-code
add polyline model to DetectedLaneBoundary
2f2675a 
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@0815-code
test_non_asci fix
91120e6 
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@0815-code 0815-code force-pushed the feature/tp/add_polyline_model_#484 branch from 82d6daf to 91120e6 Compare November 9, 2022 09:30
@jdsika
Copy link
Contributor

jdsika commented Nov 11, 2022

This PR has commits regarding the build pipeline which would need to be removed. Als #666 had some changes regarding Antora?

@ThomasNaderBMW
Copy link
Contributor

@ThomasSchloemicherAVL : Is this change still a requirement and needed?

@0815-code
Copy link
Contributor Author

@ThomasNaderBMW yes please. @jdsika yes sorry, that was my mistake after a rebase.

@thomassedlmayer
Copy link
Contributor

@ThomasSchloemicherAVL: Would you like to join the OSI Other Models Working Group (22nd of May; 9-10am) to present and discuss the intention and further proceeding for this PR in the group? Some weeks ago we still had some open questions/concerns but it could be merged for OSI 3.6 after some adaptions. Also, the build pipeline stuff should get fixed at some point.

@thomassedlmayer thomassedlmayer added this to the V3.6.0 milestone May 8, 2023
@0815-code
Copy link
Contributor Author

@ThomasSchloemicherAVL: Would you like to join the OSI Other Models Working Group (22nd of May; 9-10am) to present and discuss the intention and further proceeding for this PR in the group? Some weeks ago we still had some open questions/concerns but it could be merged for OSI 3.6 after some adaptions. Also, the build pipeline stuff should get fixed at some point.

@thomassedlmayer sorry for the late reply. Yes, please add me to that meeting..

@thempen thempen added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Jul 31, 2023
@jdsika jdsika modified the milestones: V3.6.0, V3.7.0 Apr 25, 2024
@ClemensLinnhoff
Copy link
Contributor

Is this still a valid PR? If yes, should it be included in v.3.7.0?

@pmai
Copy link
Contributor

pmai commented Apr 26, 2024

OSI 3.7.0 is closed for new features.

@pmai pmai removed this from the V3.7.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Harmonisation The Group in the ASAM development project working on harmonisation with other standards. Other Models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@0815-code @jdsika @ThomasNaderBMW @thomassedlmayer @ClemensLinnhoff @pmai @thempen @philipwindecker