Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications on curbs and other boundaries with a height #608

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

clemenshabedank
Copy link
Contributor

@clemenshabedank clemenshabedank commented Jan 19, 2022

modifications and clarifications for curbs and other lane boundaries having a 'height'

Signed-off-by: Habedank Clemens qxs2704@europe.bmw.corp

#### Reference to a related issue in the repository
Add a reference to a related issue in the repository.

Add a description

This PR is a suggestion which was preceded by discussion in the Road Model WP. It is basically reasoned by certain unclarities in the current definition of curbs:

  • Do the boundary points describing a curb lie "inside" the curb on the level of the lower side of the curb? Because a lane boundary has a width going to the left/right from its middle...
  • In wich direction points the height? Currently there is no surface definition (see Add Longitudinal Rotation of Lane Boundaries #436)
  • Is it allowed to have a lane boundary of type curb referenced from the left and the right lane? Should this take the height of the curb into account (e.g. for sidewalk yes, for normal driving lane no)?

This definition tries to fix those unclarities and needs to be seen in combination with #600

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

…having a 'height'

Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
@clemenshabedank clemenshabedank added the RoadModel4.0 A label to collect road model topics for OSI 4.0 label Jan 19, 2022
Habedank Clemens added 2 commits January 19, 2022 14:06
…n line with curb definitions in other standards

Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
@clemenshabedank
Copy link
Contributor Author

With the latest change in 6526e0a this PR is seen more as a bugfix to the current definition, because modelling curbs with only one laneboundary of type curb and a height field makes the height of adjacent lanes ambiguous. This PR makes it clearer that a curb must be modelled with two laneboundary's while deprecation of TYPE_CURB can of course be done in v4.0 earliest.

@clemenshabedank
Copy link
Contributor Author

The basic issue is now resolved by #634. This PR can be closed by future Road Model work if not seen helpful.

2 similar comments
@clemenshabedank
Copy link
Contributor Author

The basic issue is now resolved by #634. This PR can be closed by future Road Model work if not seen helpful.

@clemenshabedank
Copy link
Contributor Author

The basic issue is now resolved by #634. This PR can be closed by future Road Model work if not seen helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RoadModel4.0 A label to collect road model topics for OSI 4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant