Skip to content

Add driver assistance notification #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

caspar-ai
Copy link
Contributor

@caspar-ai caspar-ai commented Aug 19, 2021

Reference to a related issue in the repository

#545

Add a description

Adds the state of driver assist features to the existing VehicleClassification structure. Given that is inside a MovingObject, and therefore inside a TrafficUpdate message it is possible for a SuT (or any other traffic participants) to provide information about such assistance features to 3rd parties.

Of particular interest here is verification systems that want to test whether a particular feature was triggered / cancelled at the expected times.

See the linked issue for more details.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

This review is still in draft while it is under discussion so not looking to sort all checklist items at this time.

@caspar-ai caspar-ai requested review from pmai and kmeids August 19, 2021 12:25
@caspar-ai caspar-ai self-assigned this Aug 19, 2021
Designed to allow communication of what features are currently active and/or enabled, for example, ADAS features such as AEB or FCW.

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
With optional ways of customising to allow more flexibility but also common features.

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
@caspar-ai caspar-ai force-pushed the 545-add-custom-notification branch from 34b49f6 to 6a08d7b Compare August 20, 2021 14:15
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
@caspar-ai caspar-ai marked this pull request as ready for review August 20, 2021 15:30
@caspar-ai caspar-ai added FeatureRequest Proposals which enhance the interface or add additional features. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Aug 20, 2021
@stefancyliax
Copy link
Contributor

This has no milestone planning. For what release is this sensible to include? @caspar-ai

@caspar-ai
Copy link
Contributor Author

This has no milestone planning. For what release is this sensible to include? @caspar-ai

I don't know if I understand enough about how OSI releases are determined to provide a good answer. From a semantic versioning point of view, this isn't a breaking change so can go in whatever the next minor release is after the change is merged.

Does that help?

@stefancyliax
Copy link
Contributor

Yes that helps! We have this on the agenda for the CCB. If there are no major discussion it may be put in 3.4, otherwise 4.0 is the next planned release.

@kmeids
Copy link

kmeids commented Sep 15, 2021

Output CCB 15.09.2021:

  1. @caspar-ai could you please join the next CCB meeting for further discussions (13.11.2021), I'll forward the invitation?
  2. Also take a look at https://github.com/OpenSimulationInterface/open-simulation-interface/pull/547/files

@kmeids
Copy link

kmeids commented Oct 13, 2021

CCB output 13.10.2021:

  1. Extract "DriverAssistState" into a new top-level message (an e.g. of a top level message is SensorView) and in a new .proto file which will later help including it in other OSI messages, e.g. HostVehicleData.

@kmeids kmeids removed the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Oct 13, 2021
As the data isn't externally perceivable.  Instead, include it as a new top level message.

Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
@caspar-ai caspar-ai marked this pull request as draft October 15, 2021 17:05
@caspar-ai
Copy link
Contributor Author

Moving this PR to draft as it is more natural for this work to build on top of the proposed changes to HostVehicleData. That is covered by #589

Leaving this open for now, but as a draft, while discussions are ongoing.

@caspar-ai
Copy link
Contributor Author

This has now been properly superseded by #589 - closing this PR.

@caspar-ai caspar-ai closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest Proposals which enhance the interface or add additional features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants