-
Notifications
You must be signed in to change notification settings - Fork 130
Add driver assistance notification #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Designed to allow communication of what features are currently active and/or enabled, for example, ADAS features such as AEB or FCW. Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
With optional ways of customising to allow more flexibility but also common features. Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
34b49f6
to
6a08d7b
Compare
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
This has no milestone planning. For what release is this sensible to include? @caspar-ai |
I don't know if I understand enough about how OSI releases are determined to provide a good answer. From a semantic versioning point of view, this isn't a breaking change so can go in whatever the next minor release is after the change is merged. Does that help? |
Yes that helps! We have this on the agenda for the CCB. If there are no major discussion it may be put in 3.4, otherwise 4.0 is the next planned release. |
Output CCB 15.09.2021:
|
CCB output 13.10.2021:
|
As the data isn't externally perceivable. Instead, include it as a new top level message. Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Signed-off-by: Caspar de Haes <caspar.dehaes@five.ai>
Moving this PR to draft as it is more natural for this work to build on top of the proposed changes to HostVehicleData. That is covered by #589 Leaving this open for now, but as a draft, while discussions are ongoing. |
This has now been properly superseded by #589 - closing this PR. |
Reference to a related issue in the repository
#545
Add a description
Adds the state of driver assist features to the existing
VehicleClassification
structure. Given that is inside aMovingObject
, and therefore inside aTrafficUpdate
message it is possible for a SuT (or any other traffic participants) to provide information about such assistance features to 3rd parties.Of particular interest here is verification systems that want to test whether a particular feature was triggered / cancelled at the expected times.
See the linked issue for more details.
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
This review is still in draft while it is under discussion so not looking to sort all checklist items at this time.