Skip to content

534 add architecture overview #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2021
Merged

Conversation

max-rosin
Copy link
Contributor

@max-rosin max-rosin commented Jun 18, 2021

This PR resolves #534

  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • Appropriate reviewer(s) are assigned.

Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com>
…ocs (#534)

Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com>
@max-rosin max-rosin added the Documentation Everything which impacts the quality of the documentation and guidelines. label Jun 18, 2021
@max-rosin max-rosin added this to the V3.4.0 milestone Jun 18, 2021
@max-rosin max-rosin self-assigned this Jun 18, 2021
@max-rosin max-rosin linked an issue Jun 18, 2021 that may be closed by this pull request
@max-rosin max-rosin added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Jun 24, 2021
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com>
OSI contains an object-based environment description using the message format of the https://github.com/protocolbuffers/protobuf/wiki[Protocol Buffer] library developed and maintained by Google.
OSI defines top-level messages that are used to exchange data between separate models.
Top-level messages define the ``GroundTruth`` interface, the ``SensorData`` interface and, since OSI version 3.0.0, the ``SensorView``, ``SensorViewConfiguration`` and ``FeatureData`` interfaces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is right, but maybe HostVehicleData has to be added here (depending on CCB-decission).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trafficCommand, trafficUpdate?

Copy link
Contributor Author

@max-rosin max-rosin Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added text that mentions these three interfaces. Please check out 7e3325c.

… to description (#534)

Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com>
@max-rosin max-rosin merged commit cbd3882 into migration Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Everything which impacts the quality of the documentation and guidelines. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add content to architecture overview
2 participants