Avoid duplication of pylons in enum #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se there is a separate TYPE_PYLON
clemenshabedank
added
SensorModeling
|
Output from SM meeting 16.04.2021:
|
kmeids
added
the
ReadyForCCBReview
kmeids
added
ReadyToMerge
|
Output CCB 12.05.2021:
|
kmeids
approved these changes
May 12, 2021
There was a problem hiding this comment.
Output CCB 12.05.2021:
- @clemenshabedank Please fix DCO and merge
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
clemenshabedank
force-pushed
the
bugfix/sm/pylons
branch
from
7bf0996 to
9b203bb
Compare
Signed-off-by: Viktor Kreschenski <viktor.kreschenski@altran.com> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
…ark colors with OpenDRIVE Signed-off-by: Pierre R. Mai <pmai@pmsf.de> Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
…nterface/open-simulation-interface into bugfix/sm/pylons Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed cones as an example from TYPE_CONSTRUCTION_SITE_ELEMENT because there is a separate TYPE_PYLON.
@kmeids can you have a look please. @ThomasNaderBMW FYI
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!