Skip to content

Extension of the hostVehicleData #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 178 commits into from
Closed

Extension of the hostVehicleData #441

wants to merge 178 commits into from

Conversation

ThomasNaderBMW
Copy link
Contributor

@ThomasNaderBMW ThomasNaderBMW commented Nov 6, 2020 •
edited
Loading

As this is a bigger PR, feedback is welcome! :)

Reference to a related issue in the repository

Out of WP15. Integration in traffic_update has to be done.
-> Interface between dynamics (incl. restbussimulation) and simulation environment.

Add a description

Host vehicle data is about the perception of the vehicle about it's own, internal states.
It describes data that the host vehicle knows about itself,
e.g. from location sensors, internal sensors, board net etc.
A dynamic model can serve as input provider.
Sensors, mockups or other modules can make usage of the host vehicle data.
It consists of different messages categorizing the vehicle in:
Vehicle-Basics, Vehicle-Powermanagement, Vehicle-Powertrain, Vehicle-SteeringWheel, Vehicle-Wheels, Vehicle-Localization.

Mention a member

@ALL

Check the checklist

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@ThomasNaderBMW ThomasNaderBMW mentioned this pull request Dec 14, 2020
Closed
pmai and others added 29 commits January 26, 2021 13:45
@pmai
Reserve fields above 10000 for extensions (#346)
3ad8be3 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@pmai
Fixup of wording for #346
1739be3 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@jdsika
Update version file according to new release 3.2.0
5bb812a 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@jdsika
Changed file names, added release description for v3.2.0
0af1a86 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@vkresch
Documentation/interface convention (#380)
7974066 
* Changed numeric list for citation
* Adding interface naming convention
* Added section about the use of UNKNOWN in GT
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@vkresch
Update release names (#381)
15fb4e5 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@jdsika
Release documentation: (#382)
71bb84c 
* Release documentation:

* Replace links to commit hash with link to release page

* replaced all commit hashs in release notes

Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@pmai
Fix reference for left version of StVO 214 (#383)
c22e072 
Documentation bug probably due to 2017 renumbering of signs
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@MarcelOliver
Fix image reference for StVO 222 and 222-10
7bb9950 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@kino3
fix missing link to Windows installation
a0a8519 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@pmai
Move badge to travis-ci.com infrastructure
6e27e30 
Administrative Change
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@engelben
Add DCO information to Contribution Guidelines
7219fc2 
Signed-off-by: Ben Engel <benjamin.engel@asam.net>
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@engelben @pmai
Remove suggestion to use -f in git push
c7dc1d4 
Co-authored-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@pmai
Add commit-msg hook example for DCO checking
0fca3b0 
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
6805d20 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
91ec81d 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
00ed4d0 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@Krishna626
Update osi_hostvehicledata.proto
7892fdc 
- suggestion for protobuf description
- replaced engine with motor to avoid explicitly defining engine for interfaces
- reorganised wheel arragement--> anti clockwise starting from front left wheel
- Naming suggestion for VehicleLocalization--> renamed as Vehicle GEOPosition
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
d6531e5 
Made some adaptions, so it can be build.
Also some  simplifications, so it is not to much at the beginning.
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
d80490f 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
89d3511 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
00fc1b0 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
dc9a377 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
17325be 
Some improvements regarding architectural issues and out of definition reasons.
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
8fc6c0d 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
4a4d1d0 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
551bba4 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
b525273 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
833492d 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
ThomasNaderBMW and others added 21 commits June 30, 2021 16:00
@ThomasNaderBMW
Update osi_hostvehicledata.proto
1637dd7 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Fullfilled a rebase with sign off.
63ef7a1 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Edited trafficupdate.proto
42ba6da 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
included host_vehicle_data
832b831 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Suggestions regarding Range.
4b31b9d 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@0815-code @ThomasNaderBMW
Add HostVehicleData to SensorData #480
95ea2b2 
Signed-off-by: Schlömicher Thomas <thomas.schloemicher@avl.com>
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@0815-code @ThomasNaderBMW
fix semicolon
f74c2cb 
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@ThomasNaderBMW
Deleted the import of object.proto
bae3655
@0815-code @ThomasNaderBMW
remove host vehicle data from sensor data again
b97d5d2 
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@0815-code @ThomasNaderBMW
add InterfaceVersion and Timestamp to host vehicle data
adbd196 
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@0815-code @ThomasNaderBMW
remove osi_hostvehicledata.proto again from osi_sensordata.proto
d70472e 
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@ThomasNaderBMW
Position Information is now on a postprocessed level.
8758e66 
Signed-off-by: Nader Thomas <a442105@europe.bmw.corp>
@ThomasNaderBMW
Adaptions like requested in PR#488 and redefiniton of what ist HostVe…
de55aa8 
…hicleData about

Signed-off-by: Nader Thomas <thomas.nader@bmw.de>
@ThomasNaderBMW
Update osi_hostvehicledata.proto
babb7a7
@0815-code @ThomasNaderBMW
fix comments
b2ba557 
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
@ThomasNaderBMW
Update regarding: Added ENU coordinate system specifications to HostV…
e3e68fb 
…ehicleData #488

Update regarding this PR: Added ENU coordinate system specifications to HostVehicleData #488
@ThomasNaderBMW
Rename location to base, GeodeticPosition as submessage
cae1442
@ThomasNaderBMW
Deleted Powermanagement, Updated Wheels and SteeringWheel
1df1fa6
@ThomasNaderBMW
Update regarding Issue #481
1cc2182 
Signed-off-by: Nader Thomas <thomas.nader@bmw.de>
@ThomasNaderBMW
Merge branch 'Extension_osi_hostvehicledata' of https://github.com/Op…
89cd42d 
…enSimulationInterface/open-simulation-interface into Extension_osi_hostvehicledata

# Conflicts:
#	osi_hostvehicledata.proto
#	osi_trafficupdate.proto
@ThomasNaderBMW
Delete osi_trafficupdate.proto.orig
0e90613
ThomasNaderBMW added a commit that referenced this pull request Jun 30, 2021
@ThomasNaderBMW
New Branch and update of the necessary changes from PR "Extension of …
4879953 
…the hostVehicleData #441" (before it broke down).

Signed-off-by: Nader Thomas <thomas.nader@bmw.de>
@ThomasNaderBMW ThomasNaderBMW mentioned this pull request Jun 30, 2021
Merged
6 tasks
ThomasNaderBMW added a commit that referenced this pull request Sep 13, 2021
@ThomasNaderBMW
New Branch and update of the necessary changes from PR "Extension of …
23fd47c 
…the hostVehicleData #441" (before it broke down).

Signed-off-by: Nader Thomas <thomas.nader@bmw.de>
Signed-off-by: spider <Thomas.Nader@bmw.de>
@stefancyliax
Copy link
Contributor

@ThomasNaderBMW @kmeids
Since this wasn't discussed today, how is the chance this will be ready for merging in the next days? Otherwise we would need to shift it to 4.0.

@ThomasNaderBMW
Copy link
Contributor Author

@stefancyliax : This is the broken precessor of #547
So this PR does not need to be merged (but the 547 one).
I will close it out of that reason.

ThomasNaderBMW added a commit that referenced this pull request Oct 11, 2021
@ThomasNaderBMW
New Branch and update of the necessary changes from PR "Extension of …
e7f2fe0 
…the hostVehicleData #441" (before it broke down).

Signed-off-by: Nader Thomas <thomas.nader@bmw.de>
Signed-off-by: spider <Thomas.Nader@bmw.de>
Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>
pmai pushed a commit that referenced this pull request Oct 19, 2021
@ThomasNaderBMW @pmai
New Branch and update of the necessary changes from PR "Extension of …
0e7070d 
…the hostVehicleData #441" (before it broke down).

Signed-off-by: spider <Thomas.Nader@bmw.de>
Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>
pmai pushed a commit that referenced this pull request Oct 19, 2021
@ThomasNaderBMW @pmai
New Branch and update of the necessary changes from PR "Extension of …
fbac8c3 
…the hostVehicleData #441" (before it broke down).

Signed-off-by: Nader Thomas <thomas.nader@bmw.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmai pmai pmai left review comments

@jola6897 jola6897 jola6897 left review comments

@Krishna626 Krishna626 Krishna626 left review comments

@0815-code 0815-code 0815-code left review comments

@thempen thempen Awaiting requested review from thempen

Assignees

@ThomasNaderBMW ThomasNaderBMW

Labels
None yet
Projects
None yet
Milestone
V3.4.0
Development

Successfully merging this pull request may close these issues.

Add Gnss and Imu Sensor Measurements Add timestamp to host_vehicle_location