-
Notifications
You must be signed in to change notification settings - Fork 130
Experimental: Add Flatbuffers support #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Checking and testing OSI #427 Environment Linux (Ubuntu 20.04) How to register flatbuffers as a submodule Move to the directory where OSI is stored and register flatbuffers with the following command. $ cd open-simulation-interface .gitmodules file is automatically created and contains the contents. Modify CMakeList.txt When I create a Makefile using CMakeList.txt presented in $ mkdir build error: /home/OSI/test/osi_version.proto:5: 42: error: unable to load include file: google/protobuf/descriptor.proto The reason for this error is that the Protocol Buffers installation directory cannot be found when compiling with flatc. Add parameter: -I "${PROTOBUF_IMPORT_DIRS}" *** CMakeLists.txt 2021-05-12 09:34:47.159944775 +0900 *** 102,108 **** *** 116,122 **** I was able to generate the fbs file with this without any problems. |
OSI CCB:
|
5697d26
to
81cde6b
Compare
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
81cde6b
to
5e9d0d6
Compare
@stefancyliax this should now be up-to-date with master, and could be merged, but is missing a reviewer (can't self-review). If it builds, can be merged as is. |
Thanks. Will do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This draft PR is a placeholder to highlight the ongoing work for adding support for Flatbuffers encoding of OSI messages. This work is performed as part of the Performance & Packaging WP.
Currently it supports generation of the code for Flatbuffers encoding, by auto-mapping of OSI3 proto files. It does not yet include examples making use of this encoding. Also note that use of Flatbuffers encoding is not on-the-wire compatible with OSI3 using ProtoBuffers for obvious reasons.