Zoom centered on the playhead, if visible #2938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cursor is not over the canvas (Ctrl-mousewheel zooming), and the playhead is visible, center zooming at the playhead x-position.
ferdnyc
added
the
interface
This was referenced Aug 31, 2019
Reusable utility functions which encapsulate logic for determining whether a given timeline position is currently scrolled into view.
|
Looking good! Some conflicts though... |
|
I think I resolved everything correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the git history for
src/timeline/js/controllers.js, I noticed commit 492f68c which added centering around the mouse cursor for Ctrl+mousewheel zooming.I'll be honest, I never even knew about that feature! But, inspired by it, I added logic to compute the playhead position and use that location to center the zoom, if the cursor isn't over the canvas and the playhead is currently visible on-screen. So, scale adjustments using the zoom slider / buttons will try to keep the playhead visible while zooming.
If the playhead is scrolled offscreen in either direction, the code falls back to the usual centering at the left edge of the canvas.
My editor also cleaned up a whole bunch of non-blank blank lines, sorry. Someday I'm just going to stop apologizing for that.