Persist undo/redo history correctly across OpenShot sessions #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry is a huge data set of undo/redo actions). Also, do not save or load update actions of type "load". Also clear actionHistory when loading a new project. These changes should prevent the OSP project file from becoming HUGE. At most, 15 changes in the undo and redo history should only increase file size by 100k or less (which I think is a fair trade off).
|
Does this address the other cross-session history bug from #1923, the problem that absolute (transition) paths in the history data from AppImage sessions turn into crashers for future sessions, if that history is actually used? (Because the referenced paths are no longer mounted.) |
|
@ferdnyc Nope, that is not addressed. However, I am looking at that now. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of fixes to history (undo/redo) persistence, to ultimately prevent HUGE OSP project files. The reason project files would get huge was due to a bug which saved "load" actions (which load an entire OSP project file) into the history. These actions contained a copy of the undo/redo history. So over time, loading a project multiple times, it would create a exponentially larger OSP project file, each containing the previous nested version. This will no longer happen thanks to this PR!