More framerates for YouTube HD and Vimeo HD presets #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youtube supports upload of video at any frame rate.[1] Given OpenShot's sensitivity to framerate changes, it doesn't make sense that the YouTube-HD preset only offers 25fps and 29.97fps choices for Video Profile. This change adds in 23.978fps, 24fps, and 30fps options for both 720p and 1080p. I wanted to add the higher frame rates as well (50, 59.94, and 60 fps), but the "High" bitrate setting of 8Mbps doesn't meet their recommended bitrate of 12Mbps for 1080p video at those rates[1], and there's currently no way to make export bitrate dependent on frame rate. Given its increasing popularity, though, a separate "YouTube-60fps" preset with higher video bitrates might be warranted. [1]: https://support.google.com/youtube/answer/1722171
Like YouTube, Vimeo accepts video at any frame rate.[1] So, this makes the same change as the previous commit, adding additional frame rates <= 30fps. However, Vimeo's recommended bitrate is 10-20Mbps for 1080p video[1], so the video bitrate bins also get tweaked from 2/5/8 Mbps to 4/8/12 Mbps. [1]: https://vimeo.com/help/compression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Youtube and Vimeo both support upload of video at any frame rate.
Given OpenShot's sensitivity to framerate changes, it doesn't make sense that the presets only offer 25fps and 29.97fps choices for Video Profile, practically forcing the user to perform an unsupported frame-rate change on export. This change expands the profile list in both presets by adding 23.978fps, 24fps, and 30fps options in both 720p and 1080p.
I wanted to add the higher frame rates as well (50, 59.94, and 60 fps), but the "High" bitrate setting of 8Mbps doesn't meet either site's recommendations for higher frame rates, and there's currently no way to make export bitrate dependent on frame rate.
The Vimeo bitrates didn't even meet their recommendations for standard frame rate at 1080p, actually, so the bins in that preset get tweaked from 2/5/8 Mbps to 4/8/12 Mbps.
Given the increasing popularity of 60fps video on YouTube, a separate "YouTube-60fps" preset with higher video bitrates might be warranted.