Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP Trace does now show modified callid after topology_hiding #459

Open
digipigeon opened this issue Apr 12, 2015 · 13 comments
Open

SIP Trace does now show modified callid after topology_hiding #459

digipigeon opened this issue Apr 12, 2015 · 13 comments
Assignees
Milestone

Comments

@digipigeon
Copy link

In 2.1 using topology_hiding module and sip_trace the callid is re-written correctly, however this is not shown with data gathered by the SIP trace module.

@vladpaiu
Copy link
Member

Hello,

Indeed, currently SIP trace will log the caller side callid for both incoming and outgoing SIP messages.

Now, this can be an advantage, since it will make putting traces together and plotting them alot easier when compared to having two different call-ids and having to fetch all the SIP messages for those two callids.

Why do you need the callid from the callee end in the actual sip trace ? Having that in the CDRs is possible by using the $TH_callee_callid pvar.

Best Regards,
Vlad

@bogdan-iancu bogdan-iancu added this to the 2.1 milestone Apr 14, 2015
@digipigeon
Copy link
Author

There is no advantage of the SIP Trace showing something different than what is actually happening.

I need the SIP Trace to accurately reflect the packets on the wire, I don't really think this needs more of an explanation.

@vladpaiu vladpaiu added the bug label Apr 22, 2015
@digipigeon
Copy link
Author

Just checked and this is resolved now with 2.2

@digipigeon
Copy link
Author

My apologies I prematurely closed this ticket. It turns out that 2.2 still shows the original callid rather than the one after topology hiding takes place.

@digipigeon digipigeon reopened this Jul 13, 2017
@digipigeon
Copy link
Author

Hi, is it possible to get an update on this issue please?

@danielrycaj
Copy link

It is not resolved in 3.1

@jpyle490
Copy link

It does not appear to be resolved in 3.2, either.

@bogdan-iancu
Copy link
Member

woow, an +8 years ongoing ticket 🤕

@bogdan-iancu
Copy link
Member

Could anyone summarize here which messages are not properly traced ? reply/request , in/out ...... ??

@jpyle490
Copy link

In my case, all messages are traced, but those leaving OpenSIPS have the wrong SIP Call-ID (different than what's in the message). They have the original Call-ID as received, not the new Call-ID as created by topology_hiding("C").

@vtzan
Copy link

vtzan commented Jun 20, 2023

In my case, all messages are traced, but those leaving OpenSIPS have the wrong SIP Call-ID (different than what's in the message). They have the original Call-ID as received, not the new Call-ID as created by topology_hiding("C").

Which version do you use on that scenario?

@jpyle490
Copy link

In my case, all messages are traced, but those leaving OpenSIPS have the wrong SIP Call-ID (different than what's in the message). They have the original Call-ID as received, not the new Call-ID as created by topology_hiding("C").

Which version do you use on that scenario?

3.2.12 (x86_64/linux)

@bogdan-iancu
Copy link
Member

I did some tests and code digging in order to understand the problem here.
The affected sip messages (requests and replies) are the received/inbound ones, requiring an update of the call-id. The outbound messages are properly traces.
Now, what happens with the inbound ones - the TH works on a very very low level, using some pre-script raw callbacks that gives access to the msg buffer before being converted into a sip_msg structure. The TH module is doing that to be sure it is restoring the callid before doing anything else. While the tracer module uses SIP level callbacks, based on sip_msg, transactions and dialogs....so it is tracing after_ the TH is doing its callid restoring.
Next step - see if there is any solution here....

@bogdan-iancu bogdan-iancu modified the milestones: 2.1.4, 3.5-dev Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants