You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The file src/XCCDF_POLICY/xccdf_policy_remediate.c demonstrates a lot of negative practices:
the file has 1892 lines
functions are very long and have high cognitive complexity
code is duplicated sometimes
the logic for results-oriented and profile-oriented fixes is combined together
some functions have a lot of parameters
We propose to refactor this file and split it into multiple modules. You can extract functions and extract common code. Also, some code is valuable for the other modules and therefore could be moved to the common directory.
OpenSCAP Version:
Current upstream main branch as of 2024-08-02 as of HEAD 66b58f1.
Operating System & Version:
All
Steps to Reproduce:
Open src/XCCDF_POLICY/xccdf_policy_remediate.c
Examine the code
Actual Results:
See the Description of Problem section.
Expected Results:
The items mentioned in the Description of Problem section are addressed.
Additional Information / Debugging Steps:
no
The text was updated successfully, but these errors were encountered:
Description of Problem:
The file src/XCCDF_POLICY/xccdf_policy_remediate.c demonstrates a lot of negative practices:
We propose to refactor this file and split it into multiple modules. You can extract functions and extract common code. Also, some code is valuable for the other modules and therefore could be moved to the common directory.
OpenSCAP Version:
Current upstream main branch as of 2024-08-02 as of HEAD 66b58f1.
Operating System & Version:
All
Steps to Reproduce:
Actual Results:
See the Description of Problem section.
Expected Results:
The items mentioned in the Description of Problem section are addressed.
Additional Information / Debugging Steps:
no
The text was updated successfully, but these errors were encountered: