Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with newer verison of procps #1896

Open
havardAasen opened this issue Nov 21, 2022 · 3 comments
Open

Compatibility with newer verison of procps #1896

havardAasen opened this issue Nov 21, 2022 · 3 comments

Comments

@havardAasen
Copy link
Contributor

There has been some changes with the newer (> 4.0) version of procps(-ng) library. It seems they no longer include proc/devname.h, which is needed for the files src/OVAL/probes/unix/process58_probe.c and src/OVAL/probes/unix/process_probe.c.

Not sure what's best action moving forward, politely ask procps maintainer to include the header again, or just rely on compat/dev_to_tty.c.

@evgenyz
Copy link
Contributor

evgenyz commented Nov 21, 2022

Well, Fedora and RHEL are using compat/dev_to_tty.c without procps-ng-devel. So far I'm not aware of any problems related to that.

@evgenyz
Copy link
Contributor

evgenyz commented Nov 21, 2022

I mean, default package configuration is not to ask for that header. Which is the config most of our users are facing.

@havardAasen
Copy link
Contributor Author

Hmmm, yes, the only reference I could find in the documentation was this.

wget lua which procps-ng initscripts chkconfig sendmail bzip2 rpm-build strace

And that's not the development package.

Could the references in the code and CMake be removed? This will likely only lead to confusion, especially with the latest release of procps that' don't even have the necessary header. Then we are forced to use compat/dev_to_tty.c regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants