-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random sampling as alternative to beam search. #1157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master back into our fork.
…e, random sampling is done by default when the beam_size = 1 and the sampling_temp > 0.
merging master back in
Closed
guillaumekln
requested changes
Jan 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks better than the previous PR and random sampling is very good to have.
P.S.: I still think we can merge beam search, greedy search, and random sampling together with some careful abstractions but that's another work.
coder1729
reviewed
Jan 6, 2019
guillaumekln
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does a few things things.
[1] Caccia, Massimo, et al. "Language GANs Falling Short." arXiv preprint arXiv:1811.02549 (2018). https://arxiv.org/pdf/1811.02549.pdf
[2] Fan, Angela, Mike Lewis, and Yann Dauphin. "Hierarchical Neural Story Generation." arXiv preprint arXiv:1805.04833 (2018). https://arxiv.org/abs/1805.04833