Cleanup OMCSessionZMQ #295
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntron
force-pushed
the
OMCSessionZMQDocker
branch
from
30b52d6 to
d3ea385
Compare
syntron
force-pushed
the
OMCSessionZMQDocker
branch
from
d3ea385 to
e41076d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMCSessionZMQ handles different tasks:
a) start OMC process (local / via docker / via docker container)
b) connect to OMC process via ZMQ
c) connect to OMC using ZMQ
This PR tries to find a way to to split these items into several classes:
[1] OMCSessionZMQ - for b) and c)
[2] OMCProcess / OMCProcessLocal / OMCProcessDummy / OMCProcessDocker(?) - for a)
I started to work on this due to the docker code just sitting there without much usage in my case. Save for docker, all other test run fine ...
Still work in progress; feel free to comment if this even makes sense ...
On top of PR #291