Convert Exception to Throwable in Mage_Core_Block_Template.

[kiatng]

Description (*)

This will save some hours for developers, which need to see exceptions. Without this change, a whole class of errors are not caught. See discussion #2606.

Related Pull Requests

PR #1442 is not going to be merged anytime soon, so why not fix this file first.

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit c5c34fc. ± Comparison against base commit 2946fcb.

[luigifab]

I'm not sure, but this create a new problem.

With a fresh installation of OpenMage without any changes, developer mode disabled, log enabled, PHP 8.0.
Create an error in app/design/frontend/rwd/default/template/persistent/customer/form/login.phtml, for example add: Mage::get();

With Throwable line 262 in Mage_Core_Block_Template:

• exception.log: Error: Call to undefined method Mage::get() in app/design/frontend/rwd/default/template/persistent/customer/form/login.phtml:22
• but also system.log: HEADERS ALREADY SENT: \<pre>[0] app/code/core/Mage/Core/Controller/Response/Http.php:45
• the webpage (index.php/customer/account/login/) is working without some blocks

With Exception line 262 in Mage_Core_Block_Template:

• exception.log: not created
• system.log: not created
• the webpage (index.php/customer/account/login/) isn't working (like an exit)

Solution seems to add (not sure):

        } catch (Throwable $e) {
            if (!$do) { // here
                ob_get_clean();
                $do = true; // here
            }
            if (Mage::getIsDeveloperMode()) {
                throw $e;
            }
            Mage::logException($e);
        }

[luigifab]

There is another problem, YES NOT SAME.

Create an error in app/code/core/Mage/Customer/controllers/AccountController.php for loginAction, for example add: Mage::get();. Go to frontend and go to the login page, result: blank page (error 500), no logs.

An incomplete solution is to change in Mage.php for run(:

diff --git a/app/Mage.php b/app/Mage.php
@@ -741,7 +738,7 @@ final class Mage
         } catch (Mage_Core_Model_Store_Exception $e) {
             require_once(self::getBaseDir() . DS . 'errors' . DS . '404.php');
             die();
-        } catch (Exception $e) {
+        } catch (Throwable $e) {
             if (self::isInstalled()) {
                 self::printException($e);
                 exit();

Then, instead of a blank page, the error report page is displayed, and a report is created.

[luigifab]

But if you read the error report, it is "incomplete".
The source file and line number are not displayed.

This fix the problem (but not fully tested):

diff --git a/app/Mage.php b/app/Mage.php
@@ -968,11 +965,13 @@ final class Mage

             print $e->getMessage() . "\n\n";
             print $e->getTraceAsString();
+            print "\n" . '  thrown in <b>' . $e->getFile() . '</b> on line <b>' . $e->getLine() . '</b>' . "\n" . '  catched by Mage::printException()';
             print '</pre>';
         } else {
             $reportData = [
                 (!empty($extra) ? $extra . "\n\n" : '') . $e->getMessage(),
-                $e->getTraceAsString()
+                $e->getTraceAsString() .
+                "\n" . '  thrown in ' . $e->getFile() . ' on line ' . $e->getLine() . "\n" . '  catched by Mage::printException()'
             ];

             // retrieve server data

[ADDISON74]

If it is an issue we should investigate it. I will allocate time for it.

[sreichel]

@luigifab can you please open new issues for this?