Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated lib Net/IDNA2 to latest version #1181

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Updated lib Net/IDNA2 to latest version #1181

merged 1 commit into from
Sep 14, 2020

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 3, 2020

Description (*)

Updated to latest version to fix last PHP7.4 deprecated warnings ... https://github.com/pear/Net_IDNA2/commits/master

Related Pull Requests

  1. fix php7.4 syntax deprecated warnings #859

Manual testing scenarios (*)

  1. see https://github.com/OpenMage/magento-lts/pull/1173/checks?check_run_id=1048372650

Questions or comments

  • Mage_Eav will be fixed in own PR

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel sreichel added the PHP 7.x Related to PHP 7.x label Sep 3, 2020
@github-actions github-actions bot added the Component: lib/* Relates to lib/* label Sep 3, 2020
@sreichel sreichel mentioned this pull request Sep 3, 2020
Merged
3 tasks
@seansan
Copy link
Contributor

seansan commented Sep 7, 2020

Can we merge all php4 tagged items? (after review of course)

colinmollenhour
colinmollenhour approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but is this code even in use anywhere?

@sreichel
Copy link
Contributor Author

Approve, but is this code even in use anywhere?

It is used in

  • Mage_Core_Helper_Url
  • Zend_Validate_Hostname (app/code/core/Zend)

@Flyingmana Flyingmana merged commit 7fc0fab into OpenMage:1.9.4.x Sep 14, 2020
@sreichel sreichel deleted the hotfix/php-74/lib-idna2 branch September 14, 2020 22:16
@sreichel sreichel added this to the Release 19.4.7 / 20.0.3 milestone Sep 15, 2020
aldrahastur pushed a commit to aldrahastur/magento-lts that referenced this pull request Sep 22, 2020
@sreichel @aldrahastur
Updated lib Net/IDNA2 to latest version (OpenMage#1181)
9835f9d 
Co-authored-by: Sven Reichel <sven.reichel@sandstein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

Assignees
No one assigned
Labels
Component: lib/* Relates to lib/* PHP 7.x Related to PHP 7.x
Projects
None yet
Milestone
Release 19.4.7 / 20.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @seansan @colinmollenhour @Flyingmana