-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code reviews welcome #973
Comments
Woooha :)) Thanks @colinmollenhour for latest reviews .... with |
I'm doing what I can, those things are brutal. :) Nice work though, and thanks also to @tmotyl for being first to review them! |
Only 17 small one left ... nice 👍 |
Thanks @colinmollenhour for merging last ones, thanks for reviews .... I already work on Adminhtml` and it su* .... it is painful. |
@sreichel would it be possible to add some static analysis with whitelist for the modules which are fixed now, or is it too early? |
@tmotyl yes i can do, but ...
|
Can we use fork https://github.com/vianetz/phpstan-magento1/ (which sounds to be compatible) directly or does it require additional changes (then I would go for a fork in openmage) |
I'll try it out over the weekend. |
Hey
i'm contributing here since years, now i ask for your help. Please do some reviews,
I spent weeks to add doc blocks and annotions to make work easier. These PRs are nearly one year old and still lack of reviews. They are not perfect and can/will be improved ....
I'd like to help with "serious" problems, but I also want to have the code style issues been fixed ....
Thanks!
The text was updated successfully, but these errors were encountered: