Can't retrieve entity config (after delete extension)

[sreichel]

Preconditions (*)

1. main branch, works on v19

Bug comes from #2993

Steps to reproduce (*)

1. install an extension that has custom eav attributes
2. uninstall, but leave orphan db entries
3. open admin panel

Expected result (*)

1. works

Actual result (*)

Can't retrieve entity config: ave_sizechart/eav_attribute

#0 /var/www/html/app/code/core/Mage/Core/Model/Resource.php(280): Mage::throwException('Can't retrieve ...')
#1 /var/www/html/app/code/core/Mage/Core/Model/Resource/Db/Abstract.php(269): Mage_Core_Model_Resource->getTableName('ave_sizechart/e...')
#2 /var/www/html/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php(480): Mage_Core_Model_Resource_Db_Abstract->getTable('ave_sizechart/e...')
#3 /var/www/html/app/code/core/Mage/Core/Model/Resource/Db/Collection/Abstract.php(565): Mage_Core_Model_Resource_Db_Collection_Abstract->getTable('ave_sizechart/e...')
#4 /var/www/html/app/code/core/Mage/Eav/Model/Resource/Entity/Attribute/Collection.php(112): Mage_Core_Model_Resource_Db_Collection_Abstract->join('ave_sizechart/e...', 'additional_tabl...')
#5 /var/www/html/app/code/core/Mage/Eav/Model/Entity/Type.php(110): Mage_Eav_Model_Resource_Entity_Attribute_Collection->setEntityTypeFilter(Object(Mage_Eav_Model_Entity_Type))
#6 /var/www/html/app/code/core/Mage/Eav/Model/Config.php(212): Mage_Eav_Model_Entity_Type->getAttributeCollection()
#7 /var/www/html/app/code/core/Mage/Eav/Model/Config.php(172): Mage_Eav_Model_Config->_loadEntityAttributes(Object(Mage_Eav_Model_Entity_Type), 0)
#8 /var/www/html/app/code/core/Mage/Eav/Model/Config.php(386): Mage_Eav_Model_Config->_initializeStore()
#9 /var/www/html/app/code/core/Mage/Eav/Model/Entity/Abstract.php(267): Mage_Eav_Model_Config->getEntityType('customer')
#10 /var/www/html/app/code/core/Mage/Customer/Model/Resource/Customer.php(33): Mage_Eav_Model_Entity_Abstract->setType('customer')
#11 /var/www/html/app/code/core/Mage/Core/Model/Config.php(1447): Mage_Customer_Model_Resource_Customer->__construct(Array)

[addison74]

How do you uninstall the extension? In the case of Ave_SizeChart, I have a list of all the changes that the extension makes during installation and I delete them manually. Nothing remains behind. The developer, although he had a list of steps, it was not complete, there were a lot of residues left behind.

[sreichel]

How do you uninstall the extension?

Just removed code. M1 never finished support for uninstalling modules ... so its very common that orphan DB entries remain, but this should not cause errors now.

[addison74]

Now I understand. The error should not occur as long as you removed the configuration file from /app/etc/modules.

@davidhiendl - Could you please investigate this issue?

[davidhiendl]

@addison74 This is caused by the getTableName function not finding the XML model-class name registration anymore when loading an attribute model class that (probably) does not exist anymore as well. The reason it previously didn't raise an error is because entity types were lazy-loaded and now they aren't (all at once to reduce DB query & allow caching for performance).

Need to think about how to best mitigate this without introducing performance issues.

[davidhiendl]

I think I found a good way to mitigate this without introducing an issue by verifying that the module class is registered before attempting to load them and including non-existent ones. The only thing I'm concerned about is that it will be very hard to understand what's happening when a mistake was made when writing new attribute related classes. I might have to do something like error/log only if Mage::isDeveloperMode.

[fballiano]

@davidhiendl do you have news on this? I'm writing this just not to forget it :-)

[davidhiendl]

@fballiano I did not forget, but I've noticed some problems in production with my current solution.

[davidhiendl]

Sorry for the delay, testing a new solution right now for side-effects in production. If it works I will submit a PR next week.

[addison74]

@davidhiendl - any updates to solve this issue?

[davidhiendl]

Yes, I have a patch that I tested in production. I'll try to create a PR this week, just didn't have the time yet.