Skip to content

Commit 9b656d8

Browse files
FlyingmanaFlyingmana
authored
add ReturnTypeWillChange to various Files catched by code style checker (#2302)
* add ReturnTypeWillChange to Zend_Reflection methods * add ReturnTypeWillChange to remaining Zend files * add ReturnTypeWillChange to remaining Varien and Mage files
1 parent 6902359 commit 9b656d8

File tree

15 files changed

+33
-0
lines changed

15 files changed

+33
-0
lines changed

‎lib/Mage/Backup/Filesystem/Iterator/File.php‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ class Mage_Backup_Filesystem_Iterator_File extends SplFileObject
4040
*
4141
* @return string
4242
*/
43+
#[ReturnTypeWillChange]
4344
public function current()
4445
{
4546
return $this->_currentStatement;
@@ -48,6 +49,7 @@ public function current()
4849
/**
4950
* Iterate to next sql statement in file
5051
*/
52+
#[ReturnTypeWillChange]
5153
public function next()
5254
{
5355
$this->_currentStatement = '';
@@ -65,6 +67,7 @@ public function next()
6567
/**
6668
* Return to first statement
6769
*/
70+
#[ReturnTypeWillChange]
6871
public function rewind()
6972
{
7073
parent::rewind();

‎lib/Mage/Backup/Filesystem/Iterator/Filter.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ public function __construct(Iterator $iterator, array $filters)
5151
*
5252
* @return bool
5353
*/
54+
#[ReturnTypeWillChange]
5455
public function accept()
5556
{
5657
$current = $this->current()->__toString();

‎lib/Varien/Simplexml/Element.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ public function getParent()
7373
*
7474
* @return boolean
7575
*/
76+
#[ReturnTypeWillChange]
7677
public function hasChildren()
7778
{
7879
if (!$this->children()) {

‎lib/Zend/Feed/Reader/FeedSet.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ protected function _canonicalizePath($path)
132132
* @return mixed
133133
* @uses Zend_Feed_Reader
134134
*/
135+
#[ReturnTypeWillChange]
135136
public function offsetGet($offset)
136137
{
137138
if ($offset == 'feed' && !$this->offsetExists('feed')) {

‎lib/Zend/File/ClassFileLocator.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ public function __construct($dirOrIterator = '.')
7575
*
7676
* @return bool
7777
*/
78+
#[ReturnTypeWillChange]
7879
public function accept()
7980
{
8081
$file = $this->getInnerIterator()->current();

‎lib/Zend/Reflection/Class.php‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ public function getDocblock($reflectionClass = 'Zend_Reflection_Docblock')
8585
* @param bool $includeDocComment
8686
* @return int
8787
*/
88+
#[ReturnTypeWillChange]
8889
public function getStartLine($includeDocComment = false)
8990
{
9091
if ($includeDocComment) {
@@ -118,6 +119,7 @@ public function getContents($includeDocblock = true)
118119
* @param string $reflectionClass Name of reflection class to use
119120
* @return array Array of Zend_Reflection_Class
120121
*/
122+
#[ReturnTypeWillChange]
121123
public function getInterfaces($reflectionClass = 'Zend_Reflection_Class')
122124
{
123125
$phpReflections = parent::getInterfaces();
@@ -142,6 +144,7 @@ public function getInterfaces($reflectionClass = 'Zend_Reflection_Class')
142144
* @param string $reflectionClass Reflection class to utilize
143145
* @return Zend_Reflection_Method
144146
*/
147+
#[ReturnTypeWillChange]
145148
public function getMethod($name, $reflectionClass = 'Zend_Reflection_Method')
146149
{
147150
$phpReflection = parent::getMethod($name);
@@ -163,6 +166,7 @@ public function getMethod($name, $reflectionClass = 'Zend_Reflection_Method')
163166
* @param string $reflectionClass Reflection class to use for methods
164167
* @return array Array of Zend_Reflection_Method objects
165168
*/
169+
#[ReturnTypeWillChange]
166170
public function getMethods($filter = -1, $reflectionClass = 'Zend_Reflection_Method')
167171
{
168172
$phpReflections = parent::getMethods($filter);
@@ -186,6 +190,7 @@ public function getMethods($filter = -1, $reflectionClass = 'Zend_Reflection_Met
186190
* @param string $reflectionClass Name of Reflection class to use
187191
* @return Zend_Reflection_Class
188192
*/
193+
#[ReturnTypeWillChange]
189194
public function getParentClass($reflectionClass = 'Zend_Reflection_Class')
190195
{
191196
$phpReflection = parent::getParentClass();
@@ -209,6 +214,7 @@ public function getParentClass($reflectionClass = 'Zend_Reflection_Class')
209214
* @param string $reflectionClass Name of reflection class to use
210215
* @return Zend_Reflection_Property
211216
*/
217+
#[ReturnTypeWillChange]
212218
public function getProperty($name, $reflectionClass = 'Zend_Reflection_Property')
213219
{
214220
$phpReflection = parent::getProperty($name);
@@ -228,6 +234,7 @@ public function getProperty($name, $reflectionClass = 'Zend_Reflection_Property'
228234
* @param string $reflectionClass Name of reflection class to use
229235
* @return array Array of Zend_Reflection_Property
230236
*/
237+
#[ReturnTypeWillChange]
231238
public function getProperties($filter = -1, $reflectionClass = 'Zend_Reflection_Property')
232239
{
233240
$phpReflections = parent::getProperties($filter);

‎lib/Zend/Reflection/Extension.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ class Zend_Reflection_Extension extends ReflectionExtension
4343
* @param string $reflectionClass Name of reflection class to use
4444
* @return array Array of Zend_Reflection_Function objects
4545
*/
46+
#[ReturnTypeWillChange]
4647
public function getFunctions($reflectionClass = 'Zend_Reflection_Function')
4748
{
4849
$phpReflections = parent::getFunctions();
@@ -66,6 +67,7 @@ public function getFunctions($reflectionClass = 'Zend_Reflection_Function')
6667
* @param string $reflectionClass Name of reflection class to use
6768
* @return array Array of Zend_Reflection_Class objects
6869
*/
70+
#[ReturnTypeWillChange]
6971
public function getClasses($reflectionClass = 'Zend_Reflection_Class')
7072
{
7173
$phpReflections = parent::getClasses();

‎lib/Zend/Reflection/Function.php‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ public function getDocblock($reflectionClass = 'Zend_Reflection_Docblock')
5858
* @param bool $includeDocComment
5959
* @return int
6060
*/
61+
#[ReturnTypeWillChange]
6162
public function getStartLine($includeDocComment = false)
6263
{
6364
if ($includeDocComment) {
@@ -93,6 +94,7 @@ public function getContents($includeDocblock = true)
9394
* @param string $reflectionClass Name of reflection class to use
9495
* @return array Array of Zend_Reflection_Parameter
9596
*/
97+
#[ReturnTypeWillChange]
9698
public function getParameters($reflectionClass = 'Zend_Reflection_Parameter')
9799
{
98100
$phpReflections = parent::getParameters();

‎lib/Zend/Reflection/Method.php‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ public function getDocblock($reflectionClass = 'Zend_Reflection_Docblock')
6969
* @param bool $includeDocComment
7070
* @return int
7171
*/
72+
#[ReturnTypeWillChange]
7273
public function getStartLine($includeDocComment = false)
7374
{
7475
if ($includeDocComment) {
@@ -86,6 +87,7 @@ public function getStartLine($includeDocComment = false)
8687
* @param string $reflectionClass Name of reflection class to use
8788
* @return Zend_Reflection_Class
8889
*/
90+
#[ReturnTypeWillChange]
8991
public function getDeclaringClass($reflectionClass = 'Zend_Reflection_Class')
9092
{
9193
$phpReflection = parent::getDeclaringClass();
@@ -104,6 +106,7 @@ public function getDeclaringClass($reflectionClass = 'Zend_Reflection_Class')
104106
* @param string $reflectionClass Name of reflection class to use
105107
* @return array of Zend_Reflection_Parameter objects
106108
*/
109+
#[ReturnTypeWillChange]
107110
public function getParameters($reflectionClass = 'Zend_Reflection_Parameter')
108111
{
109112
$phpReflections = parent::getParameters();

‎lib/Zend/Reflection/Parameter.php‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ class Zend_Reflection_Parameter extends ReflectionParameter
3838
* @param string $reflectionClass Reflection class to use
3939
* @return Zend_Reflection_Class
4040
*/
41+
#[ReturnTypeWillChange]
4142
public function getDeclaringClass($reflectionClass = 'Zend_Reflection_Class')
4243
{
4344
$phpReflection = parent::getDeclaringClass();
@@ -56,6 +57,7 @@ public function getDeclaringClass($reflectionClass = 'Zend_Reflection_Class')
5657
* @param string $reflectionClass Reflection class to use
5758
* @return Zend_Reflection_Class
5859
*/
60+
#[ReturnTypeWillChange]
5961
public function getClass($reflectionClass = 'Zend_Reflection_Class')
6062
{
6163
$phpReflection = parent::getClass();
@@ -78,6 +80,7 @@ public function getClass($reflectionClass = 'Zend_Reflection_Class')
7880
* @param string $reflectionClass Reflection class to use
7981
* @return Zend_Reflection_Function|Zend_Reflection_Method
8082
*/
83+
#[ReturnTypeWillChange]
8184
public function getDeclaringFunction($reflectionClass = null)
8285
{
8386
$phpReflection = parent::getDeclaringFunction();
@@ -107,6 +110,7 @@ public function getDeclaringFunction($reflectionClass = null)
107110
*
108111
* @return string
109112
*/
113+
#[ReturnTypeWillChange]
110114
public function getType()
111115
{
112116
if ($docblock = $this->getDeclaringFunction()->getDocblock()) {

0 commit comments

Comments
 (0)