Replace remaining "sizeof" calls with "count" (#2369)

Author: Sdfendor

app/design/adminhtml/default/default/template/dashboard/grid.phtml

@@ -26,7 +26,7 @@
 ?>
 <?php
 
-$numColumns = sizeof($this->getColumns());
+$numColumns = count($this->getColumns());
 ?>
 <?php if($this->getCollection()): ?>
 <div class="grid np">

app/design/adminhtml/default/default/template/dashboard/salebar.phtml

@@ -24,7 +24,7 @@
  * @license     http://opensource.org/licenses/afl-3.0.php  Academic Free License (AFL 3.0)
  */
 ?>
-<?php if( sizeof($this->getTotals()) > 0 ): ?>
+<?php if(count($this->getTotals()) > 0): ?>
             <?php foreach( $this->getTotals() as $_total ): ?>
             <div class="entry-edit">
                 <div class="entry-edit-head"><h4><?php echo $_total['label'] ?></h4></div>

app/design/adminhtml/default/default/template/dashboard/totalbar.phtml

@@ -24,7 +24,7 @@
  * @license     http://opensource.org/licenses/afl-3.0.php  Academic Free License (AFL 3.0)
  */
 ?>
-<?php if( sizeof($this->getTotals()) > 0 ): ?>
+<?php if(count($this->getTotals()) > 0): ?>
 <div class="box" id="dashboard_diagram_totals">
     <div class="entry-edit">
         <table cellspacing="0" width="100%">

app/design/adminhtml/default/default/template/report/grid.phtml

@@ -34,7 +34,7 @@
  *  getPagerVisibility()
  *  getVarNamePage()
  */
-$numColumns = sizeof($this->getColumns());
+$numColumns = count($this->getColumns());
 ?>
 <?php if($this->getCollection()): ?>
     <?php if($this->canDisplayContainer()): ?>

app/design/adminhtml/default/default/template/sales/order/totalbar.phtml

@@ -24,7 +24,7 @@
  * @license     http://opensource.org/licenses/afl-3.0.php  Academic Free License (AFL 3.0)
  */
 ?>
-<?php if( sizeof($this->getTotals()) > 0 ): ?>
+<?php if(count($this->getTotals()) > 0): ?>
 <div class="box">
     <div class="entry-edit">
         <table border="0" cellspacing="0" width="100%">

app/design/adminhtml/default/default/template/system/currency/rate/matrix.phtml

@@ -37,8 +37,10 @@ $_rates = ( $_newRates ) ? $_newRates : $_oldRates;
         <thead>
             <tr class="headings">
                 <th class="a-right">&nbsp;</th>
-                <?php $_i = 0; foreach( $this->getAllowedCurrencies() as $_currencyCode ): ?>
-                    <th class="<?php echo (( ++$_i == (sizeof($this->getAllowedCurrencies())) ) ? 'last' : '' ) ?> a-right"><strong><?php echo $this->escapeHtml($_currencyCode) ?><strong></th>
+                <?php $_allowedCurrencies = $this->getAllowedCurrencies(); ?>
+                <?php $_allowedCurrencyCount = count($_allowedCurrencies); ?>
+                <?php $_i = 0; foreach($_allowedCurrencies as $_currencyCode): ?>
+                    <th class="<?php echo ((++$_i === $_allowedCurrencyCount) ? 'last' : '' ) ?> a-right"><strong><?php echo $this->escapeHtml($_currencyCode) ?><strong></th>
                 <?php endforeach ?>
             </tr>
         </thead>

app/design/adminhtml/default/default/template/widget/grid.phtml

@@ -35,7 +35,7 @@
  *  getPagerVisibility()
  *  getVarNamePage()
  */
-$numColumns = sizeof($this->getColumns());
+$numColumns = count($this->getColumns());
 ?>
 <?php if($this->getCollection()): ?>
     <?php if($this->canDisplayContainer()): ?>

app/design/frontend/base/default/template/catalog/product/list.phtml

@@ -32,7 +32,8 @@
  */
 ?>
 <?php
-    $_productCollection=$this->getLoadedProductCollection();
+    $_productCollection = $this->getLoadedProductCollection();
+    $_productCollectionCount = count($_productCollection);
     $_helper = $this->helper('catalog/output');
     $_params = $this->escapeHtml(json_encode(array('form_key' => $this->getFormKey())));
 ?>
@@ -46,7 +47,7 @@
     <?php $_iterator = 0; ?>
     <ol class="products-list" id="products-list">
     <?php foreach ($_productCollection as $_product): ?>
-        <li class="item<?php if( ++$_iterator == sizeof($_productCollection) ): ?> last<?php endif ?>">
+        <li class="item<?php if(++$_iterator === $_productCollectionCount): ?> last<?php endif ?>">
             <?php // Product Image ?>
             <a href="<?php echo $_product->getProductUrl() ?>" title="<?php echo $this->stripTags($this->getImageLabel($_product, 'small_image'), null, true) ?>" class="product-image"><img src="<?php echo $this->helper('catalog/image')->init($_product, 'small_image')->resize(135); ?>" width="135" height="135" alt="<?php echo $this->stripTags($this->getImageLabel($_product, 'small_image'), null, true) ?>" /></a>
             <?php // Product description ?>

app/design/frontend/base/default/template/catalogsearch/term.phtml

@@ -27,7 +27,7 @@
 <div class="page-title">
     <h1><?php echo $this->__('Popular Search Terms') ?></h1>
 </div>
-<?php if( sizeof($this->getTerms()) > 0 ): ?>
+<?php if(count($this->getTerms()) > 0): ?>
     <ul class="tags-list">
         <?php foreach ($this->getTerms() as $_term): ?>
             <li><a href="<?php echo $this->getSearchUrl($_term) ?>" style="font-size:<?php echo $_term->getRatio()*70+75 ?>%;"><?php echo $this->escapeHtml($_term->getName()) ?></a></li>

app/design/frontend/base/default/template/sales/order/recent.phtml

@@ -28,9 +28,9 @@
 <?php $_orders = $this->getOrders(); ?>
     <div class="box-head">
         <h2><?php echo $this->__('Recent Orders') ?></h2>
-        <?php if( sizeof($_orders->getItems()) > 0 ): ?><a href="<?php echo $this->getUrl('sales/order/history') ?>"><?php echo $this->__('View All') ?></a><?php endif ?>
+        <?php if(count($_orders->getItems()) > 0): ?><a href="<?php echo $this->getUrl('sales/order/history') ?>"><?php echo $this->__('View All') ?></a><?php endif ?>
     </div>
-<?php if( sizeof($_orders->getItems()) > 0 ): ?>
+<?php if(count($_orders->getItems()) > 0): ?>
     <table class="data-table" id="my-orders-table">
     <col width="1" />
     <col width="1" />